commit ca8ab11b5218bdf3bd107dc73c44396cc920e997
author Stephan Diestelhorst <stephan.diestelhorst@arm.com> Mon Jan 07 22:09:45 2019 -0500
committer Giacomo Gabrielli <giacomo.gabrielli@arm.com> Thu Jan 31 13:14:07 2019 +0000
tree 5cc58f9fe65f3f33c3b845d0b5c643c38c1d1a65
parent f0798cfd51e58313b58f9c38af386a99528e5db7

arch: Fix past end write bug in to_number for vec

The to_number for vector registers had an off-by-one bug that wrote one
byte past the destination data structure.  Overhauled the code
significantly to make the logic more clear.  This could have caused
random data corruption in the simulator itself, but also for the
simulated application when resuming from a checkpoint.

The serialisation part is frustratingly asymmetric: it uses csprintf per
byte, while deserialisation munges std::strings.

Note: both serialisation and deserialisation use the same, non-intuitive
order: despite prefixing the number with 0x, they both store the
lowest-address byte left-most; effectively turning this into a
big-endian number.  Not changing that so that checkpoints will remain
compatible, but.. brrrr!  Added notes in both places, and also dead code
that I used to test this.

Change-Id: Id775fe7335af07d8a76d4c81153591d3a009e95c
Signed-off-by: Stephan Diestelhorst <stephan.diestelhorst@arm.com>