commit 4c94dece1baf320d925cedb231489c4e0358ac5a
author Tejun Heo <tj@kernel.org> Tue Apr 28 13:06:05 2009 +0900
committer Jens Axboe <jens.axboe@oracle.com> Tue Apr 28 08:14:50 2009 +0200
tree fd0738e2f82c806e921e6c872b704cfbef3c0a1d
parent 9fd8d0e1bcb848257968d9a7d73ca4d890ea8bd1

block: don't init rq fields unnecessarily

blk_get_request() always returns properly zeroed requests.  Don't set
fields to zero/NULL unnecessarily.

[ Impact: cleanup ]

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

block/scsi_ioctl.c

diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
index bb9aa43..58cf456 100644
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -500,8 +500,6 @@
 
 	rq = blk_get_request(q, WRITE, __GFP_WAIT);
 	rq->cmd_type = REQ_TYPE_BLOCK_PC;
-	rq->data_len = 0;
-	rq->extra_len = 0;
 	rq->timeout = BLK_DEFAULT_SG_TIMEOUT;
 	rq->cmd[0] = cmd;
 	rq->cmd[4] = data;