Merge branch 'net-sched-race-fix'
Cong Wang says:
net_sched: close the race between call_rcu() and cleanup_net()
This patchset tries to fix the race between call_rcu() and
cleanup_net() again. Without holding the netns refcnt the
tc_action_net_exit() in netns workqueue could be called before
filter destroy works in tc filter workqueue. This patchset
moves the netns refcnt from tc actions to tcf_exts, without
breaking per-netns tc actions.
Patch 1 reverts the previous fix, patch 2 introduces two new
API's to help to address the bug and the rest patches switch
to the new API's. Please see each patch for details.
I was not able to reproduce this bug, but now after adding
some delay in filter destroy work I manage to trigger the
crash. After this patchset, the crash is not reproducible
any more and the debugging printk's show the order is expected
Fixes: ddf97ccdd7cb ("net_sched: add network namespace support for tc actions")
Reported-by: Lucas Bates <email@example.com>
Cc: Lucas Bates <firstname.lastname@example.org>
Cc: Jamal Hadi Salim <email@example.com>
Cc: Jiri Pirko <firstname.lastname@example.org>
Signed-off-by: Cong Wang <email@example.com>
Signed-off-by: David S. Miller <firstname.lastname@example.org>