commit bcc54f9a563f146e723ead16c76f842bcaeb694e
author Dave Jones <davej@redhat.com> Mon Mar 06 13:28:34 2006 +0100
committer Jaroslav Kysela <perex@suse.cz> Wed Mar 22 10:35:57 2006 +0100
tree 73a31717b1fb3d2b24f1d54c2b2684f90f51b99d
parent c27e8c591854ef349fdf5bec777355dae04bb48f

[ALSA] sound/isa/sb/sb_mixer.c double kfree

Modules: SB drivers

snd_ctl_add() already does the free on error.

Coverity bug #957

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/isa/sb/sb_mixer.c

diff --git a/sound/isa/sb/sb_mixer.c b/sound/isa/sb/sb_mixer.c
index 1a6ee34..490b1ca 100644
--- a/sound/isa/sb/sb_mixer.c
+++ b/sound/isa/sb/sb_mixer.c
@@ -453,10 +453,8 @@
 	strlcpy(ctl->id.name, name, sizeof(ctl->id.name));
 	ctl->id.index = index;
 	ctl->private_value = value;
-	if ((err = snd_ctl_add(chip->card, ctl)) < 0) {
-		snd_ctl_free_one(ctl);
+	if ((err = snd_ctl_add(chip->card, ctl)) < 0)
 		return err;
-	}
 	return 0;
 }