commit ca9fe1588427f246ad4c389b0170b29a432804b6
author Julia Lawall <julia@diku.dk> Sun Jun 20 13:24:35 2010 +0200
committer Jiri Kosina <jkosina@suse.cz> Mon Jun 21 13:41:54 2010 +0200
tree 79a8faa2a25efe789fb06be64bff5034c8659f65
parent 6e32819e12ffbd507eced11a1871700a387d5407

HID: eliminate a double lock in debug code

The path around the loop ends with the lock held, so the call to mutex_lock
is moved before the beginning of the loop.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@locked@
expression E1;
position p;
@@

read_lock(E1@p,...);

@r exists@
expression x <= locked.E1;
expression locked.E1;
expression E2;
identifier lock;
position locked.p,p1,p2;
@@

*lock@p1 (E1@p,...);
... when != E1
    when != \(x = E2\|&x\)
*lock@p2 (E1,...);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>