commit d0709f1e66e8066c4ac6a54620ec116aa41937c0
author David Jeffery <djeffery@redhat.com> Thu Feb 12 16:45:31 2015 +0000
committer James Morris <james.l.morris@oracle.com> Mon Feb 16 13:45:16 2015 +1100
tree dbccabd56c8031be37c2bad08eeccea4d29ee879
parent cd07db5f2770cf7f96b0202ef93533c8a9eee09f

Don't leak a key reference if request_key() tries to use a revoked keyring

If a request_key() call to allocate and fill out a key attempts to insert the
key structure into a revoked keyring, the key will leak, using memory and part
of the user's key quota until the system reboots. This is from a failure of
construct_alloc_key() to decrement the key's reference count after the attempt
to insert into the requested keyring is rejected.

key_put() needs to be called in the link_prealloc_failed callpath to ensure
the unused key is released.

Signed-off-by: David Jeffery <djeffery@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>