)]}'
{
  "commit": "d0cd64b02aa854d68ce517cb7da1fe4e4fff2653",
  "tree": "418bb9bd443c622bb0737a30860de5a883ef4d92",
  "parents": [
    "a743bbeef27b9176987ec0cb7f906ab0ab52d1da"
  ],
  "author": {
    "name": "Yonghong Song",
    "email": "yhs@fb.com",
    "time": "Wed Nov 08 11:28:45 2017 -0800"
  },
  "committer": {
    "name": "Thomas Gleixner",
    "email": "tglx@linutronix.de",
    "time": "Wed Nov 08 21:05:23 2017 +0100"
  },
  "message": "x86/idt: Remove X86_TRAP_BP initialization in idt_setup_traps()\n\nCommit b70543a0b2b6(\"x86/idt: Move regular trap init to tables\") moves\nregular trap init for each trap vector into a table based\ninitialization. It introduced the initialization for vector X86_TRAP_BP\nwhich was not in the code which it replaced. This breaks uprobe\nfunctionality for x86_32; the probed program segfaults instead of handling\nthe probe proper.\n\nThe reason for this is that TRAP_BP is set up as system interrupt gate\n(DPL3) in the early IDT and then replaced by a regular interrupt gate\n(DPL0) in idt_setup_traps(). The DPL0 restriction causes the int3 trap\nto fail with a #GP resulting in a SIGSEGV of the probed program.\n\nOn 64bit this does not cause a problem because the IDT entry is replaced\nwith a system interrupt gate (DPL3) with interrupt stack afterwards.\n\nRemove X86_TRAP_BP from the def_idts table which is used in\nidt_setup_traps(). Remove a redundant entry for X86_TRAP_NMI in def_idts\nwhile at it. Tested on both x86_64 and x86_32.\n\n[ tglx: Amended changelog with a description of the root cause ]\n\nFixes: b70543a0b2b6(\"x86/idt: Move regular trap init to tables\")\nReported-and-tested-by: Yonghong Song \u003cyhs@fb.com\u003e\nSigned-off-by: Yonghong Song \u003cyhs@fb.com\u003e\nSigned-off-by: Thomas Gleixner \u003ctglx@linutronix.de\u003e\nCc: a.p.zijlstra@chello.nl\nCc: ast@fb.com\nCc: oleg@redhat.com\nCc: luto@kernel.org\nCc: kernel-team@fb.com\nLink: https://lkml.kernel.org/r/20171108192845.552709-1-yhs@fb.com\n\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6107ee1cb8d56762ab76b0e076b52c3f838b1698",
      "old_mode": 33188,
      "old_path": "arch/x86/kernel/idt.c",
      "new_id": "014cb2fc47fff284ca58ef6603167771cb124105",
      "new_mode": 33188,
      "new_path": "arch/x86/kernel/idt.c"
    }
  ]
}
