tree 6cf146ac98bcde1e952430951046a9186227c6db
parent dece303fa3aaaf1dbaf4ddd95e8af1c16ceb7bb1
author Arnd Bergmann <arnd@arndb.de> 1481234225 +0100
committer David S. Miller <davem@davemloft.net> 1481250654 -0500

net: xgene: avoid bogus maybe-uninitialized warning

In some configurations, gcc cannot trace the state of variables
across a spin_unlock() barrier, leading to a warning about
correct code:

xgene_enet_main.c: In function 'xgene_enet_start_xmit':
../../../phy/mdio-xgene.h:112:14: error: 'mss_index' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Here we can trivially move the assignment before that spin_unlock,
which reliably avoids the warning.

Fixes: e3978673f514 ("drivers: net: xgene: Fix MSS programming")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>