| commit | 353d2063b1495bdfc0395a6c3cffd82192663e11 | [log] [tgz] |
|---|---|---|
| author | Arun Rodrigues <afrodri@gmail.com> | Fri Nov 19 17:16:18 2021 -0700 |
| committer | Bobby R. Bruce <bbruce@ucdavis.edu> | Wed Dec 01 19:01:48 2021 +0000 |
| tree | a775d68e1cd684467a4b80191ca83a58671342ef | |
| parent | 56c57db2985f222835525f94de9c18eff66031d5 [diff] |
scons: CheckLinkFlag() only adds to flags if test succeeds Previously, did not check the return of TryLink() before appending, so unsupported flags can be used when building shared libraries. This patch adds checking. Jira Issue: https://gem5.atlassian.net/browse/GEM5-1115 Change-Id: Ief62be15009cae9e02aaaa81b4d9c2d7b26e0223 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/53025 Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Reviewed-by: Gabe Black <gabe.black@gmail.com> Maintainer: Jason Lowe-Power <power.jg@gmail.com> Maintainer: Gabe Black <gabe.black@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com>