commit e1ad8035a379cea98ecef92e78d2894f60b2eedd
author Tony Gutierrez <anthony.gutierrez@amd.com> Wed Oct 26 22:47:05 2016 -0400
committer Tony Gutierrez <anthony.gutierrez@amd.com> Wed Oct 26 22:47:05 2016 -0400
tree 2d40294b1706bc4af45c8fae89f381bf7e99bfa7
parent 0a6cdff1760572bfa3cf9dffaa4a0df9fb4ae6a4

gpu-compute: move disassemle() implementation to GPUStaticInst

src/arch/hsail/insts/gpu_static_inst.cc

diff --git a/src/arch/hsail/insts/gpu_static_inst.cc b/src/arch/hsail/insts/gpu_static_inst.cc
index bbaeb13..dba2756 100644
--- a/src/arch/hsail/insts/gpu_static_inst.cc
+++ b/src/arch/hsail/insts/gpu_static_inst.cc
@@ -50,15 +50,4 @@
     {
         disassembly = opcode;
     }
-
-    const std::string&
-    HsailGPUStaticInst::disassemble()
-    {
-        if (disassembly.empty()) {
-            generateDisassembly();
-            assert(!disassembly.empty());
-        }
-
-        return disassembly;
-    }
 } // namespace HsailISA

src/arch/hsail/insts/gpu_static_inst.hh

diff --git a/src/arch/hsail/insts/gpu_static_inst.hh b/src/arch/hsail/insts/gpu_static_inst.hh
index 6a5ad50..5dcfe78 100644
--- a/src/arch/hsail/insts/gpu_static_inst.hh
+++ b/src/arch/hsail/insts/gpu_static_inst.hh
@@ -54,7 +54,6 @@
       public:
         HsailGPUStaticInst(const BrigObject *obj, const std::string &opcode);
         void generateDisassembly();
-        const std::string &disassemble();
         uint32_t instSize() { return 4; }
         bool isValid() const override { return true; }
 

src/gpu-compute/gpu_static_inst.cc

diff --git a/src/gpu-compute/gpu_static_inst.cc b/src/gpu-compute/gpu_static_inst.cc
index bcb8a5f..83b429e 100644
--- a/src/gpu-compute/gpu_static_inst.cc
+++ b/src/gpu-compute/gpu_static_inst.cc
@@ -40,3 +40,13 @@
       _instNum(0), _scalarOp(false)
 {
 }
+const std::string&
+GPUStaticInst::disassemble()
+{
+    if (disassembly.empty()) {
+        generateDisassembly();
+        assert(!disassembly.empty());
+    }
+
+    return disassembly;
+}

src/gpu-compute/gpu_static_inst.hh

diff --git a/src/gpu-compute/gpu_static_inst.hh b/src/gpu-compute/gpu_static_inst.hh
index 447e1ef..911e4f3 100644
--- a/src/gpu-compute/gpu_static_inst.hh
+++ b/src/gpu-compute/gpu_static_inst.hh
@@ -72,7 +72,7 @@
 
     virtual void execute(GPUDynInstPtr gpuDynInst) = 0;
     virtual void generateDisassembly() = 0;
-    virtual const std::string &disassemble() = 0;
+    const std::string& disassemble();
     virtual int getNumOperands() = 0;
     virtual bool isCondRegister(int operandIndex) = 0;
     virtual bool isScalarRegister(int operandIndex) = 0;