)]}' { "commit": "e923c07ab071c3215cbd12ee9cc5814c0caf719f", "tree": "84a36fc49ac6cd9ec612d4e6aa676ef0c5aab114", "parents": [ "7cdf8c00f891628f82a50945a5598d44f20c0ed5" ], "author": { "name": "Giacomo Travaglini", "email": "giacomo.travaglini@arm.com", "time": "Wed Jan 27 16:57:32 2021 +0000" }, "committer": { "name": "Giacomo Travaglini", "email": "giacomo.travaglini@arm.com", "time": "Wed Mar 24 20:51:29 2021 +0000" }, "message": "system: Fix PCI Mem range for VExpress_GEM5_VX DTS\n\nThis is addressing an issue raised in the mailing list [1]\nwhere setting up a PCI mem bar for an ethernet device\nresulted into an overlap of memory ranges:\n\nfatal: system.iobus has two ports responding within range\n[0x80000000:0x80020000]:\n system.realview.ethernet.pio\n system.iobridge.cpu_side_port\n\nThe reason for this is the following:\n\nThe PCI mem range in the DTB is using 0x40000000 (3rd word) as a\nstarting address in the PCI domain, which is linked to 0x40000000 in the\nhost domain.\n\n\u003c0x02000000 0x0 0x40000000 0x0 0x40000000 0x0 0x40000000\u003e;\n\nHowever the current mapping scheme works with simple fixed translation\nSo address 0x40000000 in the PCI domain will be mapped to 0x40000000 +\n0x40000000 \u003d 0x80000000, which is where DRAM starts\n\nThis is aligning with DTB autogeneration, which is setting up a\nPCI mem range starting at PCI address \u003d 0 [2]\n\n[1]: https://www.mail-archive.com/gem5-users@gem5.org/msg18941.html\n[2]: https://github.com/gem5/gem5/blob/v20.1.0.0/src/dev/arm/RealView.py#L161\n\nChange-Id: I4538511453cfd5143fb4613a080780dc86b2244c\nSigned-off-by: Giacomo Travaglini \u003cgiacomo.travaglini@arm.com\u003e\nReviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39915\nTested-by: kokoro \u003cnoreply+kokoro@google.com\u003e\nReviewed-by: Bobby R. Bruce \u003cbbruce@ucdavis.edu\u003e\nMaintainer: Bobby R. Bruce \u003cbbruce@ucdavis.edu\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "a84e8e3861cc3ced13d8a63aba3c58b8cc908b61", "old_mode": 33188, "old_path": "system/arm/dt/platforms/vexpress_gem5_v1_base.dtsi", "new_id": "2a561504e5f72c278bf7fbc74c46fe3e5133f4be", "new_mode": 33188, "new_path": "system/arm/dt/platforms/vexpress_gem5_v1_base.dtsi" }, { "type": "modify", "old_id": "2ea94ac16fca1c6d2cd5f705adbc7a58e5903436", "old_mode": 33188, "old_path": "system/arm/dt/platforms/vexpress_gem5_v2_base.dtsi", "new_id": "6dbaa2cda81d261174be6ee256cc718ef7a37eab", "new_mode": 33188, "new_path": "system/arm/dt/platforms/vexpress_gem5_v2_base.dtsi" } ] }