| commit | 91d83cc8a12883f2d7493b37f50487cd7f03a9e6 | [log] [tgz] |
|---|---|---|
| author | Gabe Black <gabeblack@google.com> | Wed Oct 07 06:49:23 2020 -0700 |
| committer | Gabe Black <gabeblack@google.com> | Wed Oct 14 12:06:44 2020 +0000 |
| tree | 5215657a132dc426de7ce16d6139e86ab4344b8c | |
| parent | aeb39c1441109c59915f657bccb2b5aeeb69fa34 [diff] |
misc: Standardize the way create() constructs SimObjects. The create() method on Params structs usually instantiate SimObjects using a constructor which takes the Params struct as a parameter somehow. There has been a lot of needless variation in how that was done, making it annoying to pass Params down to base classes. Some of the different forms were: const Params & Params & Params * const Params * Params const* This change goes through and fixes up every constructor and every create() method to use the const Params & form. We use a reference because the Params struct should never be null. We use const because neither the create method nor the consuming object should modify the record of the parameters as they came in from the config. That would make consuming them not idempotent, and make it impossible to tell what the actual simulation configuration was since it would change from any user visible form (config script, config.ini, dot pdf output). Change-Id: I77453cba52fdcfd5f4eec92dfb0bddb5a9945f31 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/35938 Reviewed-by: Gabe Black <gabeblack@google.com> Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br> Maintainer: Gabe Black <gabeblack@google.com> Tested-by: kokoro <noreply+kokoro@google.com>