commit 0fb142224c275d201227176a007202f3ed51211a
author Gabe Black <gabeblack@google.com> Mon Sep 18 17:13:31 2017 -0700
committer Gabe Black <gabeblack@google.com> Wed Sep 20 17:55:09 2017 +0000
tree 8801bf41f63063359f4fd2fe4727bd6e3b6774c5
parent 7fc5d4c36a090fc62c78ad427e8d9a1115121ee4

kvm: arm: Get rid of functions which just wrap the subclasses version.

The MuxingKvmGic class defined a few functions related to checkpointing which
did nothing other than call the underlying Pl390 implementation. These are
unnecessary in general, and are particularly unnecessary for the loadState
function which is a very lightly used part of the checkpointing interface.
It's not actually defined in Pl390 either, and falls through to the
underlying implementation.

Change-Id: I84aae13d4966df0f4fdd1a72aee0bf1af01392ff
Reviewed-on: https://gem5-review.googlesource.com/4760
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Curtis Dunham <curtis.dunham@arm.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com>

src/arch/arm/kvm/gic.cc

diff --git a/src/arch/arm/kvm/gic.cc b/src/arch/arm/kvm/gic.cc
index d490265..887fa8d 100644
--- a/src/arch/arm/kvm/gic.cc
+++ b/src/arch/arm/kvm/gic.cc
@@ -184,12 +184,6 @@
 }
 
 void
-MuxingKvmGic::loadState(CheckpointIn &cp)
-{
-    Pl390::loadState(cp);
-}
-
-void
 MuxingKvmGic::startup()
 {
     Pl390::startup();
@@ -221,19 +215,6 @@
     }
 }
 
-void
-MuxingKvmGic::serialize(CheckpointOut &cp) const
-{
-    // drain() already ensured Pl390 updated with KvmGic state if necessary
-    Pl390::serialize(cp);
-}
-
-void
-MuxingKvmGic::unserialize(CheckpointIn &cp)
-{
-    Pl390::unserialize(cp);
-}
-
 Tick
 MuxingKvmGic::read(PacketPtr pkt)
 {

src/arch/arm/kvm/gic.hh

diff --git a/src/arch/arm/kvm/gic.hh b/src/arch/arm/kvm/gic.hh
index 5447e6a..a2a62cd 100644
--- a/src/arch/arm/kvm/gic.hh
+++ b/src/arch/arm/kvm/gic.hh
@@ -174,15 +174,10 @@
     MuxingKvmGic(const MuxingKvmGicParams *p);
     ~MuxingKvmGic();
 
-    void loadState(CheckpointIn &cp) override;
-
     void startup() override;
     DrainState drain() override;
     void drainResume() override;
 
-    void serialize(CheckpointOut &cp) const override;
-    void unserialize(CheckpointIn &cp) override;
-
   public: // PioDevice
     Tick read(PacketPtr pkt) override;
     Tick write(PacketPtr pkt) override;