arch-arm,arch-x86: Added missing overrides
These overrides were missing, causing compilation errors when
compiling with clang 9. Noted here:
https://www.mail-archive.com/gem5-dev@gem5.org/msg35657.html
Change-Id: I6d09a0e57af3131b9172d01468d2cdcf4b444c5d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33817
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>
diff --git a/src/arch/arm/insts/branch.hh b/src/arch/arm/insts/branch.hh
index 98c06fc..bbb1cc8 100644
--- a/src/arch/arm/insts/branch.hh
+++ b/src/arch/arm/insts/branch.hh
@@ -58,7 +58,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
// Conditionally Branch to a target computed with an immediate
@@ -88,7 +88,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
// Conditionally Branch to a target computed with a register
@@ -119,7 +119,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
// Branch to a target computed with an immediate and a register
diff --git a/src/arch/arm/insts/mem.hh b/src/arch/arm/insts/mem.hh
index c7bd0ee..ad736c2 100644
--- a/src/arch/arm/insts/mem.hh
+++ b/src/arch/arm/insts/mem.hh
@@ -54,7 +54,7 @@
{}
void
- advancePC(PCState &pcState) const
+ advancePC(PCState &pcState) const override
{
if (flags[IsLastMicroop]) {
pcState.uEnd();
@@ -372,7 +372,8 @@
{}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
this->printInst(ss, Memory::AddrMd_Offset);
@@ -422,7 +423,8 @@
{}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
this->printInst(ss, Memory::AddrMd_PreIndex);
@@ -472,7 +474,8 @@
{}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
this->printInst(ss, Memory::AddrMd_PostIndex);
diff --git a/src/arch/arm/insts/mem64.hh b/src/arch/arm/insts/mem64.hh
index eb9ca54..412efb0 100644
--- a/src/arch/arm/insts/mem64.hh
+++ b/src/arch/arm/insts/mem64.hh
@@ -72,7 +72,7 @@
{}
void
- advancePC(PCState &pcState) const
+ advancePC(PCState &pcState) const override
{
if (flags[IsLastMicroop]) {
pcState.uEnd();
diff --git a/src/arch/arm/insts/pred_inst.hh b/src/arch/arm/insts/pred_inst.hh
index 8ba85c2..aa8d5d0 100644
--- a/src/arch/arm/insts/pred_inst.hh
+++ b/src/arch/arm/insts/pred_inst.hh
@@ -387,7 +387,7 @@
}
void
- advancePC(PCState &pcState) const
+ advancePC(PCState &pcState) const override
{
if (flags[IsLastMicroop])
pcState.uEnd();
diff --git a/src/arch/arm/insts/pseudo.hh b/src/arch/arm/insts/pseudo.hh
index 7b385f1..30a9826 100644
--- a/src/arch/arm/insts/pseudo.hh
+++ b/src/arch/arm/insts/pseudo.hh
@@ -128,7 +128,8 @@
public:
IllegalExecInst(ExtMachInst _machInst);
- Fault execute(ExecContext *xc, Trace::InstRecord *traceData) const;
+ Fault execute(ExecContext *xc,
+ Trace::InstRecord *traceData) const override;
};
class DebugStep : public ArmStaticInst
@@ -136,7 +137,8 @@
public:
DebugStep(ExtMachInst _machInst);
- Fault execute(ExecContext *xc, Trace::InstRecord *traceData) const;
+ Fault execute(ExecContext *xc,
+ Trace::InstRecord *traceData) const override;
};
#endif
diff --git a/src/arch/arm/insts/sve.hh b/src/arch/arm/insts/sve.hh
index 36f2ad1..c0fa29c 100644
--- a/src/arch/arm/insts/sve.hh
+++ b/src/arch/arm/insts/sve.hh
@@ -66,7 +66,7 @@
dest(_dest), imm1(_imm1), imm2(_imm2)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
class SveIndexIROp : public ArmStaticInst {
@@ -82,7 +82,7 @@
dest(_dest), imm1(_imm1), op2(_op2)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
class SveIndexRIOp : public ArmStaticInst {
@@ -98,7 +98,7 @@
dest(_dest), op1(_op1), imm2(_imm2)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
class SveIndexRROp : public ArmStaticInst {
@@ -114,7 +114,7 @@
dest(_dest), op1(_op1), op2(_op2)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
// Predicate count SVE instruction.
@@ -133,7 +133,7 @@
srcIs32b(_srcIs32b), destIsVec(_destIsVec)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
// Predicate count SVE instruction (predicated).
@@ -150,7 +150,7 @@
dest(_dest), op1(_op1), gp(_gp)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// While predicate generation SVE instruction.
@@ -166,7 +166,7 @@
dest(_dest), op1(_op1), op2(_op2), srcIs32b(_srcIs32b)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Compare and terminate loop SVE instruction.
@@ -180,7 +180,7 @@
op1(_op1), op2(_op2)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Unary, constructive, predicated (merging) SVE instruction.
@@ -195,7 +195,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Unary, constructive, unpredicated SVE instruction.
@@ -210,7 +210,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Unary with wide immediate, constructive, unpredicated SVE instruction.
@@ -227,7 +227,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Unary with wide immediate, constructive, predicated SVE instruction.
@@ -247,7 +247,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Binary with immediate, destructive, unpredicated SVE instruction.
@@ -264,7 +264,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Binary with immediate, destructive, predicated (merging) SVE instruction.
@@ -280,7 +280,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Binary with wide immediate, destructive, unpredicated SVE instruction.
@@ -297,7 +297,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Binary, destructive, predicated (merging) SVE instruction.
@@ -313,7 +313,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Binary, constructive, predicated SVE instruction.
@@ -331,7 +331,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Binary, unpredicated SVE instruction with indexed operand
@@ -346,7 +346,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Binary, unpredicated SVE instruction
@@ -363,7 +363,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Predicate logical instruction.
@@ -380,7 +380,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Predicate binary permute instruction.
@@ -396,7 +396,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE compare instructions, predicated (zeroing).
@@ -412,7 +412,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE compare-with-immediate instructions, predicated (zeroing).
@@ -429,7 +429,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Ternary, destructive, predicated (merging) SVE instruction.
@@ -445,7 +445,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Ternary with immediate, destructive, unpredicated SVE instruction.
@@ -462,7 +462,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE reductions.
@@ -477,7 +477,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE ordered reductions.
@@ -492,7 +492,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// PTRUE, PTRUES.
@@ -508,7 +508,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Integer compare SVE instruction.
@@ -526,7 +526,7 @@
dest(_dest), op1(_op1), op2(_op2), gp(_gp), op2IsWide(_op2IsWide)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Integer compare with immediate SVE instruction.
@@ -544,7 +544,7 @@
dest(_dest), op1(_op1), imm(_imm), gp(_gp)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// ADR.
@@ -570,7 +570,7 @@
offsetFormat(_offsetFormat)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Element count SVE instruction.
@@ -591,7 +591,7 @@
dstIs32b(_dstIs32b)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Partition break SVE instruction.
@@ -609,7 +609,7 @@
dest(_dest), gp(_gp), op1(_op1), isMerging(_isMerging)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Partition break with propagation SVE instruction.
@@ -627,7 +627,7 @@
dest(_dest), op1(_op1), op2(_op2), gp(_gp)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Scalar element select SVE instruction.
@@ -651,7 +651,7 @@
scalar(_scalar), simdFp(_simdFp)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE unary operation on predicate (predicated)
@@ -668,7 +668,7 @@
dest(_dest), op1(_op1), gp(_gp)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE table lookup/permute using vector of element indices (TBL)
@@ -684,7 +684,7 @@
dest(_dest), op1(_op1), op2(_op2)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE unpack and widen predicate
@@ -699,7 +699,7 @@
dest(_dest), op1(_op1)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE predicate test
@@ -714,7 +714,7 @@
op1(_op1), gp(_gp)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE unary predicate instructions with implicit source operand
@@ -728,7 +728,7 @@
dest(_dest)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE unary predicate instructions, predicated, with implicit source operand
@@ -744,7 +744,7 @@
dest(_dest), gp(_gp)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE unary predicate instructions with implicit destination operand
@@ -758,7 +758,7 @@
op1(_op1)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE unary predicate instructions with implicit destination operand
@@ -769,7 +769,7 @@
ArmStaticInst(mnem, _machInst, __opClass)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE vector - immediate binary operation
@@ -786,7 +786,7 @@
dest(_dest), op1(_op1), imm(_imm)
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Binary with immediate index, destructive, unpredicated SVE instruction.
@@ -803,7 +803,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// Unary unpredicated scalar to vector instruction
@@ -820,7 +820,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE dot product instruction (indexed)
@@ -839,7 +839,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE dot product instruction (vectors)
@@ -857,7 +857,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE Complex Instructions (vectors)
@@ -875,7 +875,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/// SVE Complex Instructions (indexed)
@@ -893,7 +893,7 @@
{}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
diff --git a/src/arch/arm/insts/sve_macromem.hh b/src/arch/arm/insts/sve_macromem.hh
index ed937a2..c38c938 100644
--- a/src/arch/arm/insts/sve_macromem.hh
+++ b/src/arch/arm/insts/sve_macromem.hh
@@ -86,14 +86,15 @@
}
Fault
- execute(ExecContext *, Trace::InstRecord *) const
+ execute(ExecContext *, Trace::InstRecord *) const override
{
panic("Execute method called when it shouldn't!");
return NoFault;
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
printMnemonic(ss, "", false);
@@ -158,14 +159,15 @@
}
Fault
- execute(ExecContext *, Trace::InstRecord *) const
+ execute(ExecContext *, Trace::InstRecord *) const override
{
panic("Execute method called when it shouldn't!");
return NoFault;
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
printMnemonic(ss, "", false);
@@ -230,14 +232,15 @@
}
Fault
- execute(ExecContext *, Trace::InstRecord *) const
+ execute(ExecContext *, Trace::InstRecord *) const override
{
panic("Execute method called when it shouldn't!");
return NoFault;
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
printMnemonic(ss, "", false);
@@ -303,14 +306,15 @@
}
Fault
- execute(ExecContext *, Trace::InstRecord *) const
+ execute(ExecContext *, Trace::InstRecord *) const override
{
panic("Execute method called when it shouldn't!");
return NoFault;
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
printMnemonic(ss, "", false);
@@ -402,14 +406,15 @@
}
Fault
- execute(ExecContext *, Trace::InstRecord *) const
+ execute(ExecContext *, Trace::InstRecord *) const override
{
panic("Execute method called when it shouldn't!");
return NoFault;
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
// TODO: add suffix to transfer and base registers
std::stringstream ss;
@@ -506,14 +511,15 @@
}
Fault
- execute(ExecContext *, Trace::InstRecord *) const
+ execute(ExecContext *, Trace::InstRecord *) const override
{
panic("Execute method called when it shouldn't!");
return NoFault;
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
// TODO: add suffix to transfer and base registers
std::stringstream ss;
diff --git a/src/arch/arm/insts/sve_mem.hh b/src/arch/arm/insts/sve_mem.hh
index 157bc17..ebf1428 100644
--- a/src/arch/arm/insts/sve_mem.hh
+++ b/src/arch/arm/insts/sve_mem.hh
@@ -67,7 +67,7 @@
}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
class SveMemPredFillSpill : public ArmStaticInst
@@ -93,7 +93,7 @@
}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
class SveContigMemSS : public ArmStaticInst
@@ -120,7 +120,7 @@
}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
class SveContigMemSI : public ArmStaticInst
@@ -147,7 +147,7 @@
}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
} // namespace ArmISA
diff --git a/src/arch/arm/insts/vfp.hh b/src/arch/arm/insts/vfp.hh
index b58f002..ae3b36d 100644
--- a/src/arch/arm/insts/vfp.hh
+++ b/src/arch/arm/insts/vfp.hh
@@ -849,7 +849,7 @@
bool flush, uint32_t rMode) const;
void
- advancePC(PCState &pcState) const
+ advancePC(PCState &pcState) const override
{
if (flags[IsLastMicroop]) {
pcState.uEnd();
diff --git a/src/arch/arm/isa/templates/sve.isa b/src/arch/arm/isa/templates/sve.isa
index 0bcf27f..f460e0e 100644
--- a/src/arch/arm/isa/templates/sve.isa
+++ b/src/arch/arm/isa/templates/sve.isa
@@ -64,7 +64,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -85,7 +85,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -106,7 +106,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -127,7 +127,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -148,7 +148,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -170,7 +170,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -191,7 +191,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -212,7 +212,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -233,7 +233,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -255,7 +255,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -276,7 +276,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -298,7 +298,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -320,7 +320,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -342,7 +342,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -364,7 +364,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -386,7 +386,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -408,7 +408,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -429,7 +429,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -450,7 +450,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -475,7 +475,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -496,7 +496,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -517,7 +517,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -538,7 +538,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -559,7 +559,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -579,7 +579,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -599,7 +599,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -621,7 +621,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -643,7 +643,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -663,7 +663,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -681,7 +681,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -701,7 +701,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -722,7 +722,7 @@
esize = sizeof(Element);
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -738,7 +738,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -756,7 +756,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -777,7 +777,7 @@
scalar_width = (sizeof(Element) == 8) ? 64 : 32;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -800,7 +800,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -814,7 +814,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -828,7 +828,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -842,7 +842,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -856,7 +856,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -870,7 +870,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -896,7 +896,7 @@
esize = sizeof(Element);
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -921,7 +921,7 @@
esize = sizeof(Element);
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -943,7 +943,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -965,7 +965,7 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
diff --git a/src/arch/arm/isa/templates/sve_mem.isa b/src/arch/arm/isa/templates/sve_mem.isa
index b5c2dc0..e1f725c 100644
--- a/src/arch/arm/isa/templates/sve_mem.isa
+++ b/src/arch/arm/isa/templates/sve_mem.isa
@@ -50,12 +50,14 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
- virtual void
- annotateFault(ArmFault *fault) {
+ void
+ annotateFault(ArmFault *fault) override
+ {
%(fa_code)s
}
};
@@ -78,12 +80,13 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
virtual void
- annotateFault(ArmFault *fault) {
+ annotateFault(ArmFault *fault) override {
%(fa_code)s
}
};
@@ -106,12 +109,13 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
virtual void
- annotateFault(ArmFault *fault) {
+ annotateFault(ArmFault *fault) override {
%(fa_code)s
}
};
@@ -420,18 +424,20 @@
}
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
virtual void
- annotateFault(ArmFault *fault)
+ annotateFault(ArmFault *fault) override
{
%(fa_code)s
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
// TODO: add suffix to transfer register
std::stringstream ss;
@@ -499,18 +505,20 @@
}
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
virtual void
- annotateFault(ArmFault *fault)
+ annotateFault(ArmFault *fault) override
{
%(fa_code)s
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
// TODO: add suffix to transfer and base registers
std::stringstream ss;
@@ -732,10 +740,11 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
ccprintf(ss, "%s", macroOp->disassemble(pc, symtab));
@@ -787,10 +796,11 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
ccprintf(ss, "%s", macroOp->disassemble(pc, symtab));
@@ -851,18 +861,20 @@
baseIsSP = isSP(_base);
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
virtual void
- annotateFault(ArmFault *fault)
+ annotateFault(ArmFault *fault) override
{
%(fa_code)s
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
printMnemonic(ss, "", false);
@@ -1114,18 +1126,20 @@
baseIsSP = isSP(_base);
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
virtual void
- annotateFault(ArmFault *fault)
+ annotateFault(ArmFault *fault) override
{
%(fa_code)s
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
printMnemonic(ss, "", false);
@@ -1187,10 +1201,11 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
ccprintf(ss, "%s", macroOp->disassemble(pc, symtab));
@@ -1224,10 +1239,11 @@
%(constructor)s;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
ccprintf(ss, "%s", macroOp->disassemble(pc, symtab));
diff --git a/src/arch/x86/insts/macroop.hh b/src/arch/x86/insts/macroop.hh
index 30a8d4f..5b27127 100644
--- a/src/arch/x86/insts/macroop.hh
+++ b/src/arch/x86/insts/macroop.hh
@@ -73,7 +73,7 @@
StaticInstPtr * microops;
StaticInstPtr
- fetchMicroop(MicroPC microPC) const
+ fetchMicroop(MicroPC microPC) const override
{
if (microPC >= numMicroops)
return badMicroop;
@@ -82,7 +82,8 @@
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
return mnemonic;
}
diff --git a/src/arch/x86/insts/microfpop.hh b/src/arch/x86/insts/microfpop.hh
index d13af31..f1dc15b 100644
--- a/src/arch/x86/insts/microfpop.hh
+++ b/src/arch/x86/insts/microfpop.hh
@@ -75,7 +75,7 @@
bool checkCondition(uint64_t flags) const;*/
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
}
diff --git a/src/arch/x86/insts/microldstop.hh b/src/arch/x86/insts/microldstop.hh
index 6994584..1ec31ca 100644
--- a/src/arch/x86/insts/microldstop.hh
+++ b/src/arch/x86/insts/microldstop.hh
@@ -113,7 +113,7 @@
}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
/**
@@ -147,7 +147,7 @@
}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
}
diff --git a/src/arch/x86/insts/micromediaop.hh b/src/arch/x86/insts/micromediaop.hh
index 79b1158..867ac0e 100644
--- a/src/arch/x86/insts/micromediaop.hh
+++ b/src/arch/x86/insts/micromediaop.hh
@@ -104,7 +104,7 @@
{}
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
class MediaOpImm : public MediaOpBase
@@ -125,7 +125,7 @@
{}
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
}
diff --git a/src/arch/x86/insts/microop.hh b/src/arch/x86/insts/microop.hh
index 151de44..e958fba 100644
--- a/src/arch/x86/insts/microop.hh
+++ b/src/arch/x86/insts/microop.hh
@@ -110,7 +110,8 @@
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream ss;
@@ -122,7 +123,7 @@
bool checkCondition(uint64_t flags, int condition) const;
void
- advancePC(PCState &pcState) const
+ advancePC(PCState &pcState) const override
{
if (flags[IsLastMicroop])
pcState.uEnd();
diff --git a/src/arch/x86/insts/microregop.hh b/src/arch/x86/insts/microregop.hh
index b1d1039..c14d332 100644
--- a/src/arch/x86/insts/microregop.hh
+++ b/src/arch/x86/insts/microregop.hh
@@ -93,7 +93,7 @@
}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
class RegOpImm : public RegOpBase
@@ -115,7 +115,7 @@
}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
}
diff --git a/src/arch/x86/insts/static_inst.hh b/src/arch/x86/insts/static_inst.hh
index 2bf93b6..bdf82d8 100644
--- a/src/arch/x86/insts/static_inst.hh
+++ b/src/arch/x86/insts/static_inst.hh
@@ -87,7 +87,7 @@
}
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
void printMnemonic(std::ostream &os, const char * mnemonic) const;
void printMnemonic(std::ostream &os, const char * instMnemonic,
@@ -175,7 +175,7 @@
}
void
- advancePC(PCState &pcState) const
+ advancePC(PCState &pcState) const override
{
pcState.advance();
}
diff --git a/src/arch/x86/isa/formats/basic.isa b/src/arch/x86/isa/formats/basic.isa
index bea8b6a..cd9ec9e 100644
--- a/src/arch/x86/isa/formats/basic.isa
+++ b/src/arch/x86/isa/formats/basic.isa
@@ -46,7 +46,7 @@
public:
// Constructor.
%(class_name)s(ExtMachInst machInst);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
diff --git a/src/arch/x86/isa/formats/cpuid.isa b/src/arch/x86/isa/formats/cpuid.isa
index f4ed015..41e2ac2 100644
--- a/src/arch/x86/isa/formats/cpuid.isa
+++ b/src/arch/x86/isa/formats/cpuid.isa
@@ -48,7 +48,7 @@
}
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
}};
diff --git a/src/arch/x86/isa/formats/monitor_mwait.isa b/src/arch/x86/isa/formats/monitor_mwait.isa
index 0733a2a..809623d 100644
--- a/src/arch/x86/isa/formats/monitor_mwait.isa
+++ b/src/arch/x86/isa/formats/monitor_mwait.isa
@@ -15,7 +15,7 @@
{ }
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
}};
@@ -50,9 +50,10 @@
public:
// Constructor.
%(class_name)s(ExtMachInst machInst);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
};
}};
@@ -94,7 +95,7 @@
}
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
}};
diff --git a/src/arch/x86/isa/formats/nop.isa b/src/arch/x86/isa/formats/nop.isa
index 1a708d1..1f52c31 100644
--- a/src/arch/x86/isa/formats/nop.isa
+++ b/src/arch/x86/isa/formats/nop.isa
@@ -54,7 +54,7 @@
}
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
}};
diff --git a/src/arch/x86/isa/formats/syscall.isa b/src/arch/x86/isa/formats/syscall.isa
index f728d7d..d4402d8 100644
--- a/src/arch/x86/isa/formats/syscall.isa
+++ b/src/arch/x86/isa/formats/syscall.isa
@@ -54,7 +54,7 @@
}
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
}};
diff --git a/src/arch/x86/isa/formats/unimp.isa b/src/arch/x86/isa/formats/unimp.isa
index b3e21ac..066ca59 100644
--- a/src/arch/x86/isa/formats/unimp.isa
+++ b/src/arch/x86/isa/formats/unimp.isa
@@ -60,10 +60,11 @@
flags[IsNonSpeculative] = true;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const;
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override;
};
/**
@@ -91,10 +92,11 @@
flags[IsNonSpeculative] = true;
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const;
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override;
};
}};
diff --git a/src/arch/x86/isa/formats/unknown.isa b/src/arch/x86/isa/formats/unknown.isa
index b24928d..9d1f5bf 100644
--- a/src/arch/x86/isa/formats/unknown.isa
+++ b/src/arch/x86/isa/formats/unknown.isa
@@ -55,10 +55,10 @@
{
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
}};
diff --git a/src/arch/x86/isa/macroop.isa b/src/arch/x86/isa/macroop.isa
index 28753ba..ccd065a 100644
--- a/src/arch/x86/isa/macroop.isa
+++ b/src/arch/x86/isa/macroop.isa
@@ -42,7 +42,8 @@
// Execute method for macroops.
def template MacroExecPanic {{
- Fault execute(ExecContext *, Trace::InstRecord *) const
+ Fault
+ execute(ExecContext *, Trace::InstRecord *) const override
{
panic("Tried to execute macroop directly!");
return NoFault;
@@ -60,7 +61,7 @@
{}
Fault
- execute(ExecContext *, Trace::InstRecord *) const
+ execute(ExecContext *, Trace::InstRecord *) const override
{
panic("Tried to execute macroop directly!");
}
@@ -89,7 +90,7 @@
%(class_name)s(ExtMachInst machInst, X86ISA::EmulEnv _env);
std::string generateDisassembly(
- Addr pc, const Loader::SymbolTable *symtab) const;
+ Addr pc, const Loader::SymbolTable *symtab) const override;
};
}
}};
diff --git a/src/arch/x86/isa/microops/debug.isa b/src/arch/x86/isa/microops/debug.isa
index af2975a..b7e3a9c 100644
--- a/src/arch/x86/isa/microops/debug.isa
+++ b/src/arch/x86/isa/microops/debug.isa
@@ -51,13 +51,14 @@
GenericISA::M5DebugFault *_fault);
Fault
- execute(ExecContext *xc, Trace::InstRecord *traceData) const
+ execute(ExecContext *xc, Trace::InstRecord *traceData) const override
{
return fault;
}
std::string
- generateDisassembly(Addr pc, const Loader::SymbolTable *symtab) const
+ generateDisassembly(Addr pc,
+ const Loader::SymbolTable *symtab) const override
{
std::stringstream response;
@@ -78,7 +79,7 @@
const char *instMnem, uint64_t setFlags,
GenericISA::M5DebugFault *_fault, uint8_t _cc);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
diff --git a/src/arch/x86/isa/microops/fpop.isa b/src/arch/x86/isa/microops/fpop.isa
index e5b15c1..7721162 100644
--- a/src/arch/x86/isa/microops/fpop.isa
+++ b/src/arch/x86/isa/microops/fpop.isa
@@ -82,7 +82,7 @@
InstRegIndex _src1, InstRegIndex _src2, InstRegIndex _dest,
uint8_t _dataSize, int8_t _spm);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
diff --git a/src/arch/x86/isa/microops/ldstop.isa b/src/arch/x86/isa/microops/ldstop.isa
index 515e69a..3480137 100644
--- a/src/arch/x86/isa/microops/ldstop.isa
+++ b/src/arch/x86/isa/microops/ldstop.isa
@@ -79,7 +79,7 @@
uint8_t _dataSize, uint8_t _addressSize,
Request::FlagsType _memFlags);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -229,9 +229,10 @@
uint8_t _dataSize, uint8_t _addressSize,
Request::FlagsType _memFlags);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
};
}};
@@ -249,9 +250,10 @@
uint8_t _dataSize, uint8_t _addressSize,
Request::FlagsType _memFlags);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
- Fault initiateAcc(ExecContext *, Trace::InstRecord *) const;
- Fault completeAcc(PacketPtr, ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
+ Fault initiateAcc(ExecContext *, Trace::InstRecord *) const override;
+ Fault completeAcc(PacketPtr, ExecContext *,
+ Trace::InstRecord *) const override;
};
}};
diff --git a/src/arch/x86/isa/microops/limmop.isa b/src/arch/x86/isa/microops/limmop.isa
index 9333c00..f703133 100644
--- a/src/arch/x86/isa/microops/limmop.isa
+++ b/src/arch/x86/isa/microops/limmop.isa
@@ -61,7 +61,7 @@
RegIndex foldOBit;
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
public:
%(class_name)s(ExtMachInst _machInst,
@@ -69,7 +69,7 @@
uint64_t setFlags, InstRegIndex _dest,
uint64_t _imm, uint8_t _dataSize);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
diff --git a/src/arch/x86/isa/microops/mediaop.isa b/src/arch/x86/isa/microops/mediaop.isa
index 4886790..3078a69 100644
--- a/src/arch/x86/isa/microops/mediaop.isa
+++ b/src/arch/x86/isa/microops/mediaop.isa
@@ -55,7 +55,7 @@
InstRegIndex _src1, InstRegIndex _src2, InstRegIndex _dest,
uint8_t _srcSize, uint8_t _destSize, uint16_t _ext);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -69,7 +69,7 @@
InstRegIndex _src1, uint16_t _imm8, InstRegIndex _dest,
uint8_t _srcSize, uint8_t _destSize, uint16_t _ext);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
diff --git a/src/arch/x86/isa/microops/regop.isa b/src/arch/x86/isa/microops/regop.isa
index 83a4e22..227d1cb 100644
--- a/src/arch/x86/isa/microops/regop.isa
+++ b/src/arch/x86/isa/microops/regop.isa
@@ -109,7 +109,7 @@
InstRegIndex _src1, InstRegIndex _src2, InstRegIndex _dest,
uint8_t _dataSize, uint16_t _ext);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
X86ISA::PCState branchTarget(const X86ISA::PCState &branchPC) const
override;
@@ -129,7 +129,7 @@
InstRegIndex _src1, uint8_t _imm8, InstRegIndex _dest,
uint8_t _dataSize, uint16_t _ext);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
X86ISA::PCState branchTarget(const X86ISA::PCState &branchPC) const
override;
diff --git a/src/arch/x86/isa/microops/seqop.isa b/src/arch/x86/isa/microops/seqop.isa
index a57dfa7..22af417 100644
--- a/src/arch/x86/isa/microops/seqop.isa
+++ b/src/arch/x86/isa/microops/seqop.isa
@@ -50,7 +50,7 @@
uint16_t _target, uint8_t _cc);
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
}};
@@ -61,7 +61,7 @@
%(class_name)s(ExtMachInst _machInst, const char * instMnem,
uint64_t setFlags, uint16_t _target, uint8_t _cc);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
X86ISA::PCState branchTarget(const X86ISA::PCState &branchPC) const
override;
diff --git a/src/arch/x86/isa/microops/specop.isa b/src/arch/x86/isa/microops/specop.isa
index f5e5a77..a7dda10 100644
--- a/src/arch/x86/isa/microops/specop.isa
+++ b/src/arch/x86/isa/microops/specop.isa
@@ -52,7 +52,7 @@
uint64_t setFlags, Fault _fault, uint8_t _cc);
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
class MicroHalt : public X86ISA::X86MicroopBase
@@ -67,10 +67,10 @@
{
}
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
std::string generateDisassembly(Addr pc,
- const Loader::SymbolTable *symtab) const;
+ const Loader::SymbolTable *symtab) const override;
};
}};
@@ -81,7 +81,7 @@
%(class_name)s(ExtMachInst _machInst, const char * instMnem,
uint64_t setFlags, Fault _fault, uint8_t _cc);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
@@ -214,7 +214,7 @@
const char * instMnem,
uint64_t setFlags);
- Fault execute(ExecContext *, Trace::InstRecord *) const;
+ Fault execute(ExecContext *, Trace::InstRecord *) const override;
};
}};
