commit 1f32846874d2e7af40fd222467a71dbcf2007309
author Gabriel Busnot <gabriel.busnot@arteris.com> Tue Jun 22 12:44:46 2021 +0200
committer Gabriel B. <gabriel.busnot@arteris.com> Mon Jul 11 09:06:22 2022 +0000
tree f030a452f66baaed8c6c569dbd6f4a987ac98289
parent 131f5f033ac62a7f9bd3968453584b526fd8c0bf

python: limit tooltip string length to 16384

Pydot limits the maximum line length to this value

JIRA:https://gem5.atlassian.net/browse/GEM5-1200

Change-Id: I0e6423b79f014695496dad279322304ae10a3978
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/61009
Maintainer: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>

src/python/m5/util/dot_writer.py

diff --git a/src/python/m5/util/dot_writer.py b/src/python/m5/util/dot_writer.py
index 1591816..fb7fb77 100644
--- a/src/python/m5/util/dot_writer.py
+++ b/src/python/m5/util/dot_writer.py
@@ -149,7 +149,13 @@
             ini_strings.append(str(param) + "=" +
                                simNode._values[param].ini_str())
     # join all the parameters with an HTML newline
+    # Pydot limit line length to 16384.
+    # Account for the quotes added later around the tooltip string
     tooltip = "
\\".join(ini_strings)
+    max_tooltip_length = 16384 - 2
+    if len(tooltip) > max_tooltip_length:
+        truncated = '... (truncated)'
+        tooltip = tooltip[:max_tooltip_length-len(truncated)] + truncated
 
     return pydot.Cluster( \
                          full_path, \