commit 344e2ae823796bd7856d1c76972579df00fe3d07
author Yu-hsin Wang <yuhsingw@google.com> Thu Sep 22 11:56:39 2022 +0800
committer Yu-hsin Wang <yuhsingw@google.com> Mon Sep 26 02:13:56 2022 +0000
tree 50c5057e7ce929f50bd50cb6dd5dbf95561fd91c
parent 5d35e225181372f559c78a0a168017bd47af00ed

systemc: associate tlm payload and gem5 packet in blocking interfaces

TlmToGem5Bridge only associates the tlm payload and gem5 packet in
nb_transport case. We should also do the samething in blocking
interfaces. Otherwise, the downstream Gem5ToTlmBridge cannot get the
correct payload.

Change-Id: I85b213402d58d68641615a6cea04961f4a15f1ba
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/63772
Reviewed-by: Gabe Black <gabe.black@gmail.com>
Maintainer: Gabe Black <gabe.black@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>

src/systemc/tlm_bridge/tlm_to_gem5.cc

diff --git a/src/systemc/tlm_bridge/tlm_to_gem5.cc b/src/systemc/tlm_bridge/tlm_to_gem5.cc
index 4cb8194..c3313da 100644
--- a/src/systemc/tlm_bridge/tlm_to_gem5.cc
+++ b/src/systemc/tlm_bridge/tlm_to_gem5.cc
@@ -219,8 +219,7 @@
     trans.acquire();
 
     auto [pkt, pkt_created] = payload2packet(_id, trans);
-    auto *tlmSenderState = new Gem5SystemC::TlmSenderState(trans);
-    pkt->pushSenderState(tlmSenderState);
+    pkt->pushSenderState(new Gem5SystemC::TlmSenderState(trans));
 
     // If the packet doesn't need a response, we should send BEGIN_RESP by
     // ourselves.
@@ -331,6 +330,7 @@
                                        sc_core::sc_time &t)
 {
     auto [pkt, pkt_created] = payload2packet(_id, trans);
+    pkt->pushSenderState(new Gem5SystemC::TlmSenderState(trans));
 
     MemBackdoorPtr backdoor = nullptr;
     Tick ticks = bmp.sendAtomicBackdoor(pkt, backdoor);
@@ -348,6 +348,13 @@
     // update time
     t += delay;
 
+    gem5::Packet::SenderState *senderState = pkt->popSenderState();
+    sc_assert(
+        nullptr != dynamic_cast<Gem5SystemC::TlmSenderState*>(senderState));
+
+    // clean up
+    delete senderState;
+
     if (pkt_created)
         destroyPacket(pkt);
 
@@ -360,8 +367,17 @@
 {
     auto [pkt, pkt_created] = payload2packet(_id, trans);
     if (pkt != nullptr) {
+        pkt->pushSenderState(new Gem5SystemC::TlmSenderState(trans));
+
         bmp.sendFunctional(pkt);
 
+        gem5::Packet::SenderState *senderState = pkt->popSenderState();
+        sc_assert(
+            nullptr != dynamic_cast<Gem5SystemC::TlmSenderState*>(senderState));
+
+        // clean up
+        delete senderState;
+
         if (pkt_created)
             destroyPacket(pkt);
     }
@@ -375,6 +391,7 @@
                                               tlm::tlm_dmi &dmi_data)
 {
     auto [pkt, pkt_created] = payload2packet(_id, trans);
+    pkt->pushSenderState(new Gem5SystemC::TlmSenderState(trans));
 
     MemBackdoorPtr backdoor = nullptr;
     bmp.sendAtomicBackdoor(pkt, backdoor);
@@ -400,6 +417,13 @@
         );
     }
 
+    gem5::Packet::SenderState *senderState = pkt->popSenderState();
+    sc_assert(
+        nullptr != dynamic_cast<Gem5SystemC::TlmSenderState*>(senderState));
+
+    // clean up
+    delete senderState;
+
     if (!pkt_created)
         destroyPacket(pkt);