commit 3e8d76e2e23ab23d68e569e9b2c4498a06c19f59
author Gabe Black <gabeblack@google.com> Sun Jan 14 11:44:04 2018 -0800
committer Gabe Black <gabeblack@google.com> Mon Jan 15 06:13:55 2018 +0000
tree 24cd226f1a7327b4969ceabe65faa44d5353df42
parent 5320a97ced43d4452014ff54c0ba45246db90a00

arch: Fix a fatal_if in most of the arch's process classes.

When switching an assert to a fatal while addressing recent review
feedback, I forgot to reverse the polarity of the condition, making
the fatal fire in exactly the opposite of the conditions it was meant
to.

Change-Id: Icf49864ef449052bbb0d427dca786006166575c4
Reviewed-on: https://gem5-review.googlesource.com/7381
Reviewed-by: Matthias Jung <jungma@eit.uni-kl.de>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>

src/arch/alpha/process.cc

diff --git a/src/arch/alpha/process.cc b/src/arch/alpha/process.cc
index bcfe362..2c6f833 100644
--- a/src/arch/alpha/process.cc
+++ b/src/arch/alpha/process.cc
@@ -52,7 +52,7 @@
     : Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
       objFile)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     Addr brk_point = objFile->dataBase() + objFile->dataSize() +
                      objFile->bssSize();
     brk_point = roundUp(brk_point, PageBytes);

src/arch/arm/process.cc

diff --git a/src/arch/arm/process.cc b/src/arch/arm/process.cc
index 5daa54a..aef714e 100644
--- a/src/arch/arm/process.cc
+++ b/src/arch/arm/process.cc
@@ -67,7 +67,7 @@
               objFile),
               arch(_arch)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
 }
 
 ArmProcess32::ArmProcess32(ProcessParams *params, ObjectFile *objFile,

src/arch/mips/process.cc

diff --git a/src/arch/mips/process.cc b/src/arch/mips/process.cc
index 76f7e86..62ccd5a 100644
--- a/src/arch/mips/process.cc
+++ b/src/arch/mips/process.cc
@@ -53,7 +53,7 @@
     : Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
               objFile)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     // Set up stack. On MIPS, stack starts at the top of kuseg
     // user address space. MIPS stack grows down from here
     Addr stack_base = 0x7FFFFFFF;

src/arch/power/process.cc

diff --git a/src/arch/power/process.cc b/src/arch/power/process.cc
index 343cd4b..22627ef 100644
--- a/src/arch/power/process.cc
+++ b/src/arch/power/process.cc
@@ -53,7 +53,7 @@
     : Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
               objFile)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     // Set up break point (Top of Heap)
     Addr brk_point = objFile->dataBase() + objFile->dataSize() +
                      objFile->bssSize();

src/arch/riscv/process.cc

diff --git a/src/arch/riscv/process.cc b/src/arch/riscv/process.cc
index 44b276a..73df5f5 100644
--- a/src/arch/riscv/process.cc
+++ b/src/arch/riscv/process.cc
@@ -64,7 +64,7 @@
                                           PageBytes),
                 objFile)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     const Addr stack_base = 0x7FFFFFFFFFFFFFFFL;
     const Addr max_stack_size = 8 * 1024 * 1024;
     const Addr next_thread_stack_base = stack_base - max_stack_size;

src/arch/sparc/process.cc

diff --git a/src/arch/sparc/process.cc b/src/arch/sparc/process.cc
index 59ef5c4..1fcb6cb 100644
--- a/src/arch/sparc/process.cc
+++ b/src/arch/sparc/process.cc
@@ -60,7 +60,7 @@
               objFile),
       StackBias(_StackBias)
 {
-    fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+    fatal_if(params->useArchPT, "Arch page tables not implemented.");
     // Initialize these to 0s
     fillStart = 0;
     spillStart = 0;