commit 59c4fd07cbc96fa22e4a32ef8c93bd958340ce65
author CHEN Meng <tundriolaxy@gmail.com> Mon Sep 20 04:31:52 2021 +0800
committer Bobby R. Bruce <bbruce@ucdavis.edu> Wed Sep 22 18:37:48 2021 +0000
tree 642952c5e87ab11f96b91fb7f5c09479d64eed98
parent 082f0835b098887f0fdb89db908b59221b027686

base-stats: fix storage initializing

Commit (70194795c3f41cc3f1e361b3cac24f839d86dd67) introduced std::vector with resize() to initializing all storages. This method caused data duplication in statistics. Storage is now initialized using loops.

Change-Id: I4350863a83671fc10cc02b5cb7d3b38e6cf4f565
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/50747
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
Reviewed-by: Hoa Nguyen <hoanguyen@ucdavis.edu>
Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>

src/base/statistics.hh

diff --git a/src/base/statistics.hh b/src/base/statistics.hh
index 18f52cb..8fc71eb 100644
--- a/src/base/statistics.hh
+++ b/src/base/statistics.hh
@@ -952,7 +952,10 @@
         fatal_if(s <= 0, "Storage size must be positive");
         fatal_if(check(), "Stat has already been initialized");
 
-        storage.resize(s, new Storage(this->info()->getStorageParams()));
+        storage.reserve(s);
+        for (size_type i = 0; i < s; ++i)
+            storage.push_back(new Storage(this->info()->getStorageParams()));
+
         this->setInit();
     }
 
@@ -1178,7 +1181,10 @@
         info->x = _x;
         info->y = _y;
 
-        storage.resize(x * y, new Storage(info->getStorageParams()));
+        storage.reserve(x * y);
+        for (size_type i = 0; i < x * y; ++i)
+            storage.push_back(new Storage(this->info()->getStorageParams()));
+
         this->setInit();
 
         return self;
@@ -1387,7 +1393,10 @@
         fatal_if(s <= 0, "Storage size must be positive");
         fatal_if(check(), "Stat has already been initialized");
 
-        storage.resize(s, new Storage(this->info()->getStorageParams()));
+        storage.reserve(s);
+        for (size_type i = 0; i < s; ++i)
+            storage.push_back(new Storage(this->info()->getStorageParams()));
+
         this->setInit();
     }