commit b65272e7f1ec24b57d92b28bd2c0c24e5f9a6325
author Gabe Black <gabe.black@gmail.com> Mon Oct 25 02:19:19 2021 -0700
committer Gabe Black <gabe.black@gmail.com> Fri Dec 03 03:24:44 2021 +0000
tree 4c912bc41e68bbb97cc6eb3f56c0a980eeaf8ec6
parent 81fa62fc912b665d35ec3982bdaabbf8cba2d6da

arch: Remove "process()" from the Decoder interface.

This method was only ever an implementation detail on ARM and x86, the
only places it actually did anything. Remove it from the other decoders,
and also make it protected on x86 to remove confusion.

Change-Id: I3a719648039c1edfbc2bd044f0a21c8983b249f5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52075
Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br>
Maintainer: Gabe Black <gabe.black@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>

src/arch/mips/decoder.hh

diff --git a/src/arch/mips/decoder.hh b/src/arch/mips/decoder.hh
index 9480bd8..d738767 100644
--- a/src/arch/mips/decoder.hh
+++ b/src/arch/mips/decoder.hh
@@ -55,11 +55,6 @@
     Decoder(ISA* isa = nullptr) : InstDecoder(&machInst)
     {}
 
-    void
-    process()
-    {
-    }
-
     //Use this to give data to the decoder. This should be used
     //when there is control flow.
     void

src/arch/power/decoder.hh

diff --git a/src/arch/power/decoder.hh b/src/arch/power/decoder.hh
index d4381ae..dcd1e53 100644
--- a/src/arch/power/decoder.hh
+++ b/src/arch/power/decoder.hh
@@ -52,11 +52,6 @@
   public:
     Decoder(ISA* isa=nullptr) : InstDecoder(&emi) {}
 
-    void
-    process()
-    {
-    }
-
     // Use this to give data to the predecoder. This should be used
     // when there is control flow.
     void

src/arch/riscv/decoder.hh

diff --git a/src/arch/riscv/decoder.hh b/src/arch/riscv/decoder.hh
index 1d3a309..718e698 100644
--- a/src/arch/riscv/decoder.hh
+++ b/src/arch/riscv/decoder.hh
@@ -67,7 +67,6 @@
   public:
     Decoder(ISA* isa=nullptr) : InstDecoder(&machInst) { reset(); }
 
-    void process() {}
     void reset() override;
 
     inline bool compressed(ExtMachInst inst) { return (inst & 0x3) < 0x3; }

src/arch/sparc/decoder.hh

diff --git a/src/arch/sparc/decoder.hh b/src/arch/sparc/decoder.hh
index 20f797a..31b3014 100644
--- a/src/arch/sparc/decoder.hh
+++ b/src/arch/sparc/decoder.hh
@@ -54,8 +54,6 @@
     Decoder(ISA* isa=nullptr) : InstDecoder(&machInst), asi(0)
     {}
 
-    void process() {}
-
     // Use this to give data to the predecoder. This should be used
     // when there is control flow.
     void

src/arch/x86/decoder.hh

diff --git a/src/arch/x86/decoder.hh b/src/arch/x86/decoder.hh
index 9bc0afe..a965fab 100644
--- a/src/arch/x86/decoder.hh
+++ b/src/arch/x86/decoder.hh
@@ -250,6 +250,8 @@
     /// @retval A pointer to the corresponding StaticInst object.
     StaticInstPtr decode(ExtMachInst mach_inst, Addr addr);
 
+    void process();
+
   public:
     Decoder(ISA *isa=nullptr) : InstDecoder(&fetchChunk)
     {
@@ -309,8 +311,6 @@
         state = ResetState;
     }
 
-    void process();
-
     // Use this to give data to the decoder. This should be used
     // when there is control flow.
     void