commit ca4c0a168ae3a48fe97f0c132fefbf606d925bb8
author Isaac Sánchez Barrera <isaac.sanchez@bsc.es> Wed Mar 20 14:32:22 2019 +0100
committer Isaac Sánchez Barrera <isaac.sanchez@bsc.es> Tue Mar 26 07:25:11 2019 +0000
tree b321f70aa9285ed1f55a6eee5a0bea3facb7c49b
parent 149c1fc2d070a8ce073263880ecf2ccf7535e569

base,python: Fix to allow multiple --debug-ignore values.

When adding multiple SimObjects to --debug-ignore, either separating the values with
a colon or adding multiple --debug-ignore flags, the previous code only ignored the
last SimObject in the list.  This changeset adds and uses new `ObjectMatch::add` and
`Logger::addIgnore` methods to make the functionality of the flag consistent with
its description.

Change-Id: Ib6967a48611ea59a211f81af2a970c4de429b1be
Signed-off-by: Isaac Sánchez Barrera <isaac.sanchez@bsc.es>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/17488
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Gabe Black <gabeblack@google.com>
Maintainer: Gabe Black <gabeblack@google.com>

src/base/match.cc

diff --git a/src/base/match.cc b/src/base/match.cc
index dc621b4..03f425f 100644
--- a/src/base/match.cc
+++ b/src/base/match.cc
@@ -44,6 +44,12 @@
 }
 
 void
+ObjectMatch::add(const ObjectMatch &other)
+{
+    tokens.insert(tokens.end(), other.tokens.begin(), other.tokens.end());
+}
+
+void
 ObjectMatch::setExpression(const string &expr)
 {
     tokens.resize(1);

src/base/match.hh

diff --git a/src/base/match.hh b/src/base/match.hh
index 6e1f03b..3ef4c81 100644
--- a/src/base/match.hh
+++ b/src/base/match.hh
@@ -47,6 +47,7 @@
   public:
     ObjectMatch();
     ObjectMatch(const std::string &expression);
+    void add(const ObjectMatch &other);
     void setExpression(const std::string &expression);
     void setExpression(const std::vector<std::string> &expression);
     bool match(const std::string &name) const

src/base/trace.hh

diff --git a/src/base/trace.hh b/src/base/trace.hh
index ddf936e..ee87372 100644
--- a/src/base/trace.hh
+++ b/src/base/trace.hh
@@ -86,6 +86,9 @@
     /** Set objects to ignore */
     void setIgnore(ObjectMatch &ignore_) { ignore = ignore_; }
 
+    /** Add objects to ignore */
+    void addIgnore(const ObjectMatch &ignore_) { ignore.add(ignore_); }
+
     virtual ~Logger() { }
 };
 

src/python/pybind11/debug.cc

diff --git a/src/python/pybind11/debug.cc b/src/python/pybind11/debug.cc
index 8fcd0cd..de8b103 100644
--- a/src/python/pybind11/debug.cc
+++ b/src/python/pybind11/debug.cc
@@ -75,7 +75,7 @@
 {
     ObjectMatch ignore(expr);
 
-    Trace::getDebugLogger()->setIgnore(ignore);
+    Trace::getDebugLogger()->addIgnore(ignore);
 }
 
 void